feature/watchdog #16

shultzp1 · 2025-10-16T08:39:47-07:00

shultzp1 commented

2025-10-16 08:39:47 -07:00

Merge watchdog with main branch

shultzp1 added 2 commits 2025-10-16 08:39:47 -07:00

Implemented WatchDog file watcher; verifies file changes and prints last modified time. All functions tested and working. 0724ba05b3

Add WatchDog and example.txt; all features tested and working ba669f6e6d

azpect commented

2025-10-16 12:15:27 -07:00

For future reference, try not to push the .vscode directory. We can use .gitignore to prevent that.

Also, we are using snake_case for class member variables:

        std::filesystem::file_time_type lastWriteTime;
        // use this
        std::filesystem::file_time_type last_write_time;

Also, I am fond of the this-> pointer, I prefer to include it even when we don't need to. Personally, I think it's easier to read. All of these things are minor, def not worth failing this PR, but for future reference try to remember these things. Once we have a style guide we can be more strict, but for now we can just change them as needed.

For future reference, try not to push the .vscode directory. We can use `.gitignore` to prevent that. Also, we are using **snake_case** for class member variables: ```c++ std::filesystem::file_time_type lastWriteTime; // use this std::filesystem::file_time_type last_write_time; ``` Also, I am fond of the `this->` pointer, I prefer to include it even when we don't need to. Personally, I think it's easier to read. All of these things are minor, def not worth failing this PR, but for future reference try to remember these things. Once we have a style guide we can be more strict, but for now we can just change them as needed.

azpect approved these changes 2025-10-16 12:16:31 -07:00

azpect left a comment

Please review my comments left in the PR, but overall, very well done!

I will aprove this and merge into main. We are going to experience merge conflicts inside the nodes, but I will handle it once I get the nodes completed and ready for review.

Please review my comments left in the PR, but overall, very well done! I will aprove this and merge into main. We are going to experience merge conflicts inside the nodes, but I will handle it once I get the nodes completed and ready for review.

azpect merged commit 3f8722cc1f into main

2025-10-16 12:16:48 -07:00

azpect deleted branch feature/watchdog

2025-10-16 12:16:48 -07:00

azpect referenced this issue from a commit

2025-10-16 12:16:49 -07:00

Merge pull request 'feature/watchdog' (#16) from feature/watchdog into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: azpect/MarkdownToHtmlTranspiler#16