(FIX): Updated the recipe of the week with optional help.

This commit is contained in:
Hayden Hargreaves 2025-11-15 23:56:10 -07:00
parent 38f3c87885
commit 6cd46cffc3
4 changed files with 50 additions and 7 deletions

View File

@ -24,4 +24,16 @@ func (s *Server) withAuthenticatedUser(ctx *gin.Context, handler AuthenticatedFu
handler(ctx, user) handler(ctx, user)
} }
// TODO: Create a function to use for methods that CAN use a user, but sometimes don't. // getUserId retrieves the userId from the context and returns a pointer to it. A nil
// pointer can be returned and will if the userId does not exist.
func getUserId(ctx *gin.Context) *int {
userIdAny, exists := ctx.Get("userId")
if !exists {
return nil
}
userIdInt, ok := userIdAny.(int)
if !ok {
return nil
}
return &userIdInt
}

View File

@ -9,7 +9,7 @@ import (
domain "github.com/haydenhargreaves/Potion/internal/domain/server" domain "github.com/haydenhargreaves/Potion/internal/domain/server"
) )
// JwtAuthMiddlewareV2 is responsible to protecting routes. Anything that may go wrong // JwtAuthMiddlewareV2 is responsible for protecting routes. Anything that may go wrong
// will be returned via JSON with a 'message' field and a 401 error code. When this // will be returned via JSON with a 'message' field and a 401 error code. When this
// middleware is successful, it will set the 'userId' and 'userEmail' fields and pass // middleware is successful, it will set the 'userId' and 'userEmail' fields and pass
// to the next function in the chain. // to the next function in the chain.
@ -63,3 +63,36 @@ func JwtAuthMiddlewareV2(jwtSecretKey []byte) gin.HandlerFunc {
ctx.Next() ctx.Next()
} }
} }
// JwtOptionalAuthMiddlewareV2 is responsible for collecting user data for routes where
// authentication is optional. Meaning: if the use is not logged in, this function does
// not fail or return, it simply does nothing. But if the user is logged in, then the
// 'userId' and 'userEmail' context values are set.
//
// e.g., `userIdAny, exists := ctx.Get("userId")`
func JwtOptionalAuthMiddlewareV2(jwtSecretKey []byte) gin.HandlerFunc {
return func(ctx *gin.Context) {
tokenString, err := ctx.Cookie("jwt_token")
if err != nil || tokenString == "" {
// No cookie found: not authenticated, but allow access
ctx.Next()
return
}
claims := &domain.JwtClaims{}
token, err := jwt.ParseWithClaims(tokenString, claims, func(token *jwt.Token) (interface{}, error) {
if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
return nil, fmt.Errorf("unexpected signing method: %v", token.Header["alg"])
}
return jwtSecretKey, nil
})
if err == nil && token.Valid {
// Set user info in context if token is valid
ctx.Set("userId", claims.UserId)
ctx.Set("userEmail", claims.Email)
}
// Otherwise, just continue (user is unauthenticated)
ctx.Next()
}
}

View File

@ -14,10 +14,8 @@ import (
// Until auth is reimplemented, there is no way to determine what user is making the // Until auth is reimplemented, there is no way to determine what user is making the
// call. // call.
func (s *Server) GetRecipeOfTheWeekHandlerV2(ctx *gin.Context) { func (s *Server) GetRecipeOfTheWeekHandlerV2(ctx *gin.Context) {
// BUG: This needs to be different, not hard coded userId := getUserId(ctx)
userId := 1 recipe, err := s.deps.RecipeService.GetRecipeOfTheWeek(userId)
recipe, err := s.deps.RecipeService.GetRecipeOfTheWeek(&userId)
if err != nil { if err != nil {
ctx.JSON(http.StatusBadRequest, gin.H{ ctx.JSON(http.StatusBadRequest, gin.H{

View File

@ -201,7 +201,7 @@ func (s *Server) Setup() *Server {
// ---- VERSION 2 ROUTES ---- // // ---- VERSION 2 ROUTES ---- //
router_api_v2 := router_v2.Group(domain.API) router_api_v2 := router_v2.Group(domain.API)
router_api_v2.GET("/recipe/of-the-week", s.GetRecipeOfTheWeekHandlerV2) router_api_v2.GET("/recipe/of-the-week", JwtOptionalAuthMiddlewareV2([]byte(cfg.JwtSecret)), s.GetRecipeOfTheWeekHandlerV2)
router_api_v2.GET("/auth/login", s.GetGoogleAuthUrlHandlerV2) router_api_v2.GET("/auth/login", s.GetGoogleAuthUrlHandlerV2)
router_api_v2.GET("/auth/callback", s.GoogleCallbackHandlerV2) router_api_v2.GET("/auth/callback", s.GoogleCallbackHandlerV2)
router_api_v2.GET("/auth/logout", s.LogoutHandlerV2) router_api_v2.GET("/auth/logout", s.LogoutHandlerV2)