azpect/Potion
1
1
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

(FEAT): Errors can now be displayed using the RenderErrorBanner fx. #44

Merged
azpect merged 3 commits from feature/errors into master 2025-09-04 20:26:05 -07:00
Conversation 1 Commits 3 Files Changed 12 +295 -50
azpect commented 2025-09-03 22:26:54 -07:00
Owner
Copy Link

This is found in the components domain. Make sure only HTMX routes call
it. Although, I think I put this into the page handlers WHICH IS WRONG.

However, it does work, ish. But it does not load into the DOM properly.
But it seems to display just fine.

This is found in the components domain. Make sure only HTMX routes call it. Although, I think I put this into the page handlers WHICH IS WRONG. However, it does work, ish. But it does not load into the DOM properly. But it seems to display just fine.
azpect added 2 commits 2025-09-03 22:26:55 -07:00 
This is found in the components domain. Make sure only HTMX routes call
it. Although, I think I put this into the page handlers WHICH IS WRONG.

However, it does work, ish. But it does not load into the DOM properly.
But it seems to display just fine.
azpect commented 2025-09-03 22:27:25 -07:00
Author
Owner
Copy Link

Before this can be merged, updates must be made to add errors to EVERY location an error can occur, not just the page_handler.go file.

Good luck...

Before this can be merged, updates must be made to add errors to EVERY location an error can occur, not just the `page_handler.go` file. Good luck...
azpect added 1 commit 2025-09-04 20:25:48 -07:00 
I think this is really the only place we need them. For now at least.
azpect merged commit 1e4cf8f922 into master 2025-09-04 20:26:05 -07:00
azpect deleted branch feature/errors 2025-09-04 20:26:05 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Infrastructure
Improve infrastructure
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Priority
PostLaunch
The priority is for post launch
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
azpect
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: azpect/Potion#44
No description provided.
Delete Branch "feature/errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?