azpect/Potion
1
1
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

(DB/FEAT): Began the implementation of the user engagement! #18

Merged
azpect merged 10 commits from feature/engagement into master 2025-07-15 21:53:17 -07:00
Conversation 2 Commits 10 Files Changed 32 +1930 -637
azpect commented 2025-07-13 21:36:28 -07:00
Owner
Copy Link

The database requirements have been added, as well as the service/repo
architecture. A few small functions have been created, but the system is
not complete by any means. More work is required to mark this task
complete.

The database requirements have been added, as well as the service/repo architecture. A few small functions have been created, but the system is not complete by any means. More work is required to mark this task complete.
azpect added 1 commit 2025-07-13 21:36:28 -07:00 
The database requirements have been added, as well as the service/repo
architecture. A few small functions have been created, but the system is
not complete by any means. More work is required to mark this task
complete.
azpect added 1 commit 2025-07-13 21:38:09 -07:00 
Templ's formatter sucks.
azpect added 1 commit 2025-07-14 18:08:11 -07:00
azpect added 1 commit 2025-07-14 21:03:35 -07:00 
The make button is pretty much done, just need to finish up by
rate limiting it. That will take place in the engagement repository.

Sharing works as well, just a UI change, there is no backend yet, maybe
there should be an engagement type for sharing recipes. But not totally
sure.

The viewing is also in a semi-working state. It does not create requests
for users that aren't signed in, which needs to come. With that update
there is a need to update HOW the requests come in, we don't need it
every time we load the page. Maybe just when we click to it, from
somewhere else?

Finally, the favoriting does not totally work. The entry into the
engagement table is complete, but the actual favorites table, favorite
creation, button toggling AND button rendering is not implemented yet.
azpect commented 2025-07-14 21:04:06 -07:00
Author
Owner
Copy Link

The commit above contains lots of notes, reference before merging.

The commit above contains lots of notes, reference before merging.
azpect added 1 commit 2025-07-14 21:31:51 -07:00 
The frontend is half wired up, just need to update the button. I also
want to update the recipe methods to return the favorite status. This
will follow very similar to the way I updated the tags. Another method
which can be called to attach the favorite state.
azpect added 2 commits 2025-07-15 19:46:13 -07:00 
This means we need to pass the user id into the various methods that
call it. But, since it is a pointer, we can use nil if we don't have a
user to check with (this is noted in the service).
I don't like the way that templ requires JS, but it is what it is. I
just don't want to return HTML from the server.
azpect added 1 commit 2025-07-15 20:16:26 -07:00 
This required some fixing of old repo methods, since the nullable user
id was a bit hard to parse. But it should be working now.
azpect commented 2025-07-15 20:16:38 -07:00
Author
Owner
Copy Link

All that is left for this is fixing the viewing engagement (when it is created), and then implementing a shared engagement, which should be very similar, almost copy-paste to the other ones.

All that is left for this is fixing the viewing engagement (when it is created), and then implementing a shared engagement, which should be very similar, almost copy-paste to the other ones.
azpect added 1 commit 2025-07-15 21:20:43 -07:00 
This includes user and no user routes! Now wired to the frontend,
however, it will still create an engagement even if it fails...
azpect added 1 commit 2025-07-15 21:46:20 -07:00 
But that means we have to redirect from the handler. I didn't want to,
but I guess that makes it easier when more pages direct to the recipe
page.
azpect merged commit d191902448 into master 2025-07-15 21:53:17 -07:00
azpect deleted branch feature/engagement 2025-07-15 21:53:17 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Infrastructure
Improve infrastructure
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Priority
PostLaunch
The priority is for post launch
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
azpect
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: azpect/Potion#18
No description provided.
Delete Branch "feature/engagement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?